Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added run, crouch, bleed status icons for RetroDays sees_player_retro mod #51208

Merged
merged 4 commits into from
Sep 9, 2021
Merged

Conversation

dranitski
Copy link
Contributor

@dranitski dranitski commented Aug 29, 2021

Summary

Interface "Status icons for sees_player_retro mod"

Purpose of change

See updated version in #51910
RetroDays sees_player_retro mod adds alert icon for enemies, but lacks run, crouch, bleed icons that i've added.

Describe the solution

Added the icons, updated the configs and mod description.

Testing

Works fine
2021-08-29_19-53 Cropped
2021-08-29_19-54 Cropped
2021-08-29_19-55 Cropped

@anothersimulacrum
Copy link
Member

How does it look on mutants with larger sprites?

@actual-nh actual-nh added [JSON] Changes (can be) made in JSON Mechanics: Effects / Skills / Stats Effects / Skills / Stats Mods Issues related to mods or modding SDL: Tiles / Sound Tiles visual interface and sounds. labels Aug 29, 2021
@dseguin
Copy link
Member

dseguin commented Aug 30, 2021

Looks like the reversible sprites might be an issue when facing left:
run_backwards
crouch_backwards

@dranitski
Copy link
Contributor Author

dranitski commented Aug 30, 2021

How does it look on mutants with larger sprites?

I am sure RetroDays don’t have any player sprites bigger than 10x10 so that may not be an issue. https://github.com/CleverRaven/Cataclysm-DDA/blob/master/gfx/RetroDaysTileset/tile_config.json

@dranitski
Copy link
Contributor Author

Looks like the reversible sprites might be an issue when facing left:
run_backwards
crouch_backwards

Maybe , "rotates": false in tile config will solve that? Will take a look

@dranitski
Copy link
Contributor Author

okay, seems like rotate: true is not connected with tile flipping. I've changed icons from C and R letters to plus signs to address that issue

image

@kevingranade kevingranade merged commit ed9baa7 into CleverRaven:master Sep 9, 2021
@anothersimulacrum
Copy link
Member

@dranitski in the 20x20 tiles:

{ "id": "overlay_male_mutation_THRESH_CATTLE", "fg": 3371 },
{ "id": "overlay_mutation_THRESH_CATTLE", "fg": 3370 },
{ "id": "overlay_mutation_THRESH_LIZARD", "fg": 3372 },
{ "id": "overlay_mutation_THRESH_URSINE", "fg": 3369 }

Venera3 pushed a commit to Venera3/Cataclysm-DDA that referenced this pull request Sep 21, 2021
… mod (CleverRaven#51208)

* added run, crouch, bleeding status icon to sees_player_retro mod

* repositioned icons for better look

* changed run and crouch icons

* Update data/mods/sees_player_retro/modinfo.json

Co-authored-by: Kevin Granade <kevin.granade@gmail.com>
@dranitski
Copy link
Contributor Author

updated version is in #51910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mechanics: Effects / Skills / Stats Effects / Skills / Stats Mods Issues related to mods or modding SDL: Tiles / Sound Tiles visual interface and sounds.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants