Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow construction to find materials while standing on stairs #51216

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

RoyBerube
Copy link
Contributor

Summary

Bugfixes "Allow construction to find materials while standing on stairs"

Purpose of change

Fixes #51187

While standing on stairs and doing a construction, the player would only see ingredients and tools in inventory.

Describe the solution

This adds a condition to not ignore the location where the player is standing when searching for ingredients/tools. If the player was on stairs it would reject that location and then all other locations would be unreachable as a result.

Describe alternatives you've considered

Changing the signature for has_floor_or_support(). This is less disruptive.

Testing

Using the construction menu while standing on stairs.

Additional context

@actual-nh actual-nh added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling labels Aug 29, 2021
@dseguin
Copy link
Member

dseguin commented Aug 30, 2021

I tried this out standing on stairs with materials nearby:
on_stairs

Without the fix, the materials are not used:
construct_nopatch

Using this PR, it seems to be fixed:
construct

@kevingranade kevingranade merged commit d55bf8b into CleverRaven:master Aug 30, 2021
@RoyBerube RoyBerube deleted the construct_on_stairs branch August 30, 2021 03:41
Venera3 pushed a commit to Venera3/Cataclysm-DDA that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Crafting / Construction / Recipes Includes: Uncrafting / Disassembling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't detect items in construction menu when on top of stairs
4 participants