Remove Int/IntCap skill rust options and make Vanilla default

[eltank]

Summary

Interface "Remove Int/IntCap skill rust options and make Vanilla default"

Purpose of change

The Int and IntCap rust options were not doing anything meaningful, other than influence Character::rust_rate() which actually has no impact on gameplay.
Also, skill rust provides benefits now so players should be encouraged to use Vanilla rather than Off.

Describe the solution

• Delete Character::rust_rate()
• Remove Int and IntCap rust options (migrating config files to Vanilla and Capped respectively)
• Update the description of the skill rust option.
• Make Vanilla the default for new games game installations

Describe alternatives you've considered

Testing

Load a save in which skill rust was set to Int. Observe that it migrated to Vanilla.
Start the game with a clean user profile. Open config/options.json and verify that SKILL_RUST is set to "vanilla".

Additional context

Before:

After:

The default value change will not affect players in the middle of a game or players starting a new game with the same "config" directory. It will only affect players installing the game for the first time or players who choose to delete their old config or change the installation directory in order to get a fresh start with all options reset to default.

[linonetwo]

Hi, we have a question:

skill rust provides benefits now

what benefit can we get from it? I know it encourages us to play in party-based gameplay, but that feature still requires debug privilege, and is not available in normal gameplay. And that is not a real benefit I think.

[I-am-Erk]

Rust doesn't have anything to do with party based gameplay really. It provides a benefit because you'll learn skills faster overall if you give them a little time to rust and then resume practicing them.

[linonetwo]

Thanks! I didn't know that, I'm going to share this with my friends.