Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crossbow bolt length #51446

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Fix crossbow bolt length #51446

merged 1 commit into from
Sep 7, 2021

Conversation

TealcOneill
Copy link
Contributor

@TealcOneill TealcOneill commented Sep 7, 2021

Summary

Bugfixes "Changes bolt length to fix rounding error."

Purpose of change

Currently crossbow bolts are too long to fit in a regular backpack but display as being able to due to a rounding error.

Describe the solution

I don't think it's unreasonable for a crossbow bolt to fit in a backpack so I simply shortened them all 6mm so that they would fit and display properly still.

Describe alternatives you've considered

Increase backpack max length or increase bolt length so that it displays as too long.

Testing

Spawned a backpack and bolts and used 'i'nsert to make sure they fit.

Additional context

Currently crossbow bolts are too long to fit in a regular backpack but display as being able to due to a rounding error. I don't think it's unreasonable for a crossbow bolt to fit in a backpack so I simply shortened them all 6mm so that they would fit and display properly still.
@actual-nh actual-nh added <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON Items: Archery Bows, crossbows, arrows, bolts Items: Containers Things that hold other things labels Sep 7, 2021
@Rivet-the-Zombie Rivet-the-Zombie merged commit 38e0a13 into CleverRaven:master Sep 7, 2021
@TealcOneill TealcOneill deleted the bolt_length branch September 10, 2021 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) Items: Archery Bows, crossbows, arrows, bolts Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants