fixes migration based bugs #51451
Merged
fixes migration based bugs #51451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several turrets had there weapons switched out using the migration system which led to miss matched names or different turrets that used the same gun but had different requirements.
anothersimulacrum
added
<Bugfix>
|
This change made my mounted nato carbine go kaput. Was there a way to make it go smoother? I had to resort to editing my save file. |
Apologies about the break, perhaps if I used migration for it that wouldn't have happened. I don't know if there's something else I can do here to keep this from happening for anyone else. @anothersimulacrum Anything you think I should do here? |
|
AFAIK there is no mechanism to deal with migration for vehicle parts. |
Venera3
pushed a commit
to Venera3/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2021
Several turrets had there weapons switched out using the migration system which led to miss matched names or different turrets that used the same gun but had different requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Using migration to replace items led to issues with blazemod turrets."
Purpose of change
Several turrets had their weapons switched out using the migration system which led to miss matched names or different turrets that used the same gun but had different requirements.
Fixes #47492
Describe the solution
Removed old turrets that now use the same weapon as another turret. Fixed misnamed turrets, and a typo in the file.
Describe alternatives you've considered
Not doing this.
Testing
Loaded in and made sure all parts were removed or renamed as appropriate and no error messages occurred.
Additional context