Actually throttle monster thinking #51460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actual-nh
added
<Bugfix>
|
This seems safe for me to merge given that the real questions were in the original throttle pr. |
|
Nice, I'll try and steal some time to test the newer dumber pets |
Venera3
pushed a commit
to Venera3/Cataclysm-DDA
that referenced
this pull request
Sep 21, 2021
* Actually throttle monster thinking * Satisfy astyle (I hope)
BrettDong
added a commit
that referenced
this pull request
Nov 27, 2021
ZhilkinSerg
pushed a commit
that referenced
this pull request
Nov 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Actually throttle monster thinking"
Purpose of change
The code in monmove.cpp's plan() function was supposed to throttle monster thinking down if there hadn't been a target for a bit. It wasn't working because the output was supposed to be "between 0.0 and 1.0"... but the variable was an int.
Describe the solution
Change it to a float.
Describe alternatives you've considered
Doing other improvements on monster AI first so they don't get too dumb.
Testing
CI for a little bit; the rest will require playtesting by people more experienced with monsters than I am (and with more time than I have in which they can concentrate). (The worry is that the monsters will get too dumb.)
Additional context
Ping: @Venera3? @LyleSY (particularly for pets)? Thanks!