Generated cities have at least size 2 #51769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Night-Pryanik
added
<Bug>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Generated cities have at least size 2."
Purpose of change
Closes #37856 - Mapgen sometimes generates completely empty towns.
Describe the solution
World option of city sizes 4 or less could sometimes generate city with size 1 or even less, which is then automatically set to a minimum of 1. Increased this minimum to size 2, so any city can have some buildings in it.
Describe alternatives you've considered
Don't generate cities with size 1 at all.
Testing
Teleported around 10 overmaps, looked at cities. No cities consisting of just crossroad observed.
Additional context
None.