Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corpse description snippets #51834

Merged
merged 8 commits into from
Sep 24, 2021
Merged

Conversation

faefux
Copy link
Contributor

@faefux faefux commented Sep 23, 2021

Summary

Content "snippets for corpses to allow for some cosmetic variation."

Purpose of change

Seen the different kinds of corpses when using them and decided corpses should have snippets to allow for variation.

Describe the solution

Wrote some quick and short snippets in the hopes that other will come to add some too.

Describe alternatives you've considered

Just not I guess.

Testing

I scrolled through them in the item debug menu to see the different tags. Everything looks in order.

Additional context

The purpose of this was mostly to encourage others to write some interesting ones too both for the corpses i gave the "snippet_category" and otherwise. So feel free to have at it.

@Maleclypse Maleclypse added [JSON] Changes (can be) made in JSON Items: Containers Things that hold other things labels Sep 23, 2021
@actual-nh
Copy link
Contributor

Ping: @Venera3?

@faefux faefux changed the title Ff corpse snippets Corpse description snippets Sep 24, 2021
data/json/items/corpses/corpses.json Outdated Show resolved Hide resolved
data/json/items/corpses/corpses.json Outdated Show resolved Hide resolved
data/json/items/corpses/corpses.json Outdated Show resolved Hide resolved
data/json/items/corpses/corpses.json Outdated Show resolved Hide resolved
data/json/items/corpses/corpses.json Outdated Show resolved Hide resolved
data/json/items/corpses/corpses.json Outdated Show resolved Hide resolved
faefux and others added 6 commits September 24, 2021 15:19
Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru>
Co-authored-by: Anton Burmistrov <Night_Pryanik@mail.ru>
@faefux
Copy link
Contributor Author

faefux commented Sep 24, 2021

Thank you, @Night-Pryanik! :)

@kevingranade kevingranade merged commit 2a24955 into CleverRaven:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants