Fix crash when repairing items #51837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused by CleverRaven#51600 which pops the current target if cannot_continue_repair is true. However, this popped target is later used as fix_location (it's a reference set earlier). This also fixes CleverRaven#51828 and CleverRaven#51674.
This was referenced Sep 24, 2021
Maleclypse
added
<Bugfix>
|
Thank you for fixing that! I should really stop making these silly mistakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Crash when repairing items"
Purpose of change
This fixes #51828 and also fixes #51674.
Describe the solution
This was caused by #51600 which pops the current target if
cannot_continue_repairistrue.However, this popped target is later used as
fix_location(it's a reference set earlier).Describe alternatives you've considered
None, fix seems straight forward.
Testing
Before: Repair something and watch it crash.
Now: Repair something and it'll work.
Additional context
@ferociousdork seemed to come to the same conclusion: #51828 (comment)