Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Bastion Fort starting scenario #54598

Merged
merged 13 commits into from Jan 21, 2022

Conversation

JonathanLochridge
Copy link
Contributor

Summary

Content "New Bastion Fort starting scenario"

Purpose of change

I thought it would be cool to be able to start in a bastion fort and have to escape out the single exit or brake a leg going over the wall.

Describe the solution

Added a New Scenario which allows starting at the Bastion Fort.
Also buffed the Forts to spawn 0-2 times per overmap square to ensure one spawns so it will work on default world settings.

Describe alternatives you've considered

Not adding it.
Or making the spawn rate slightly lower or higher.

Testing

I ran all the edited files through the Linter.
I booted it up and made fresh worlds and characters till I consistently got ones that spawned properly.

Additional context

The next step would be making the Reenactor the default profession for this start.
I think paring down the allowed professions would be a good thing to do.
I think in it's current form it is worth merging. But I am planning to do some refinement to make it a bit better.
I also ended up with more commits than I would prefer for what got done. I can't remember how to squash commits well. But I wouldn't mind some of these being squashed together.

Add Fort Start Scenario
Small thing I changed that didn't fix the issue. But I didn't want to lose. Please squash this commit later.
Update start_locations to include fort.
Also changed where the scenario points to so it grabs the start location.
Changed occurances and Scenario location name.
Also, I adjusted the spawns back down to a reasonable level.
There should be 0 to 2 per overmap tile.
Note Can't get it much lower without it giving spawn errors fairly frequently. But if we don't mind them having to reroll a map every couple of times we could bring it lower.
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Jan 20, 2022
@Night-Pryanik
Copy link
Contributor

Also buffed the Forts to spawn 0-2 times per overmap square

That's not the way it works with UNIQUE flag. This flag means, that with your change now there's a chance of 20 out of 100 (i.e. 20%) of spawning a single location on any overmap. In other words, this flag converts amount of spawned location into a probability of spawning.

@JonathanLochridge
Copy link
Contributor Author

JonathanLochridge commented Jan 20, 2022

Also buffed the Forts to spawn 0-2 times per overmap square

That's not the way it works with UNIQUE flag. This flag means, that with your change now there's a chance of 20 out of 100 (i.e. 20%) of spawning a single location on any overmap. In other words, this flag converts amount of spawned location into a probability of spawning.

I had temporarily removed the Unique Flag to try to get it to spawn. But I placed it back. With the current version 20% chance of spawning is the expected rate.
Apparently the message for being unable to spawn actually occurs after checking 100 overmaps not 3.
Thanks for your post though.

Changing min distance to account for it now counting from city edge rather than city center
Adding a Space according to a commenters suggestion

Co-authored-by: Maleclypse <54345792+Maleclypse@users.noreply.github.com>
@JonathanLochridge
Copy link
Contributor Author

Hmm, I guess one of the minor edits must have messed up the Lint. Probably should have reran it. after my final adjustments but I forgot. I can do that now then?

JonathanLochridge and others added 3 commits January 20, 2022 12:06
When the PR checks ran I realized I forgot to lint some of the files after my latest tweaks/bugfix with it.
Co-authored-by: Maleclypse <54345792+Maleclypse@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jan 20, 2022
@JonathanLochridge
Copy link
Contributor Author

So the change to make the make distance -1 seems to have triggered an error in the build process?
@Maleclypse

@Maleclypse
Copy link
Member

So the change to make the make distance -1 seems to have triggered an error in the build process? @Maleclypse

I was going to check the error but you've reverted it. No stress. If this works now leave it be.

@JonathanLochridge
Copy link
Contributor Author

So the change to make the make distance -1 seems to have triggered an error in the build process? @Maleclypse

I was going to check the error but you've reverted it. No stress. If this works now leave it be.

Oh, sorry I should have waited I guess? I think it should be in the history so you might be able to check?
But, It specifically pointed out that line in the build process. Not sure why? I will wait and see if there is still an issue after it runs again.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 21, 2022
@kevingranade kevingranade merged commit aa7b03c into CleverRaven:master Jan 21, 2022
@JonathanLochridge JonathanLochridge deleted the Fort-Scenario branch January 21, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants