Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-compiling test #58326

Merged
merged 1 commit into from
Jun 11, 2022
Merged

Fix non-compiling test #58326

merged 1 commit into from
Jun 11, 2022

Conversation

Stephen2
Copy link
Contributor

Summary

None

Purpose of change

Fixes

../tests/vehicle_fake_part_test.cpp:91:22: error: variable 'tested_a_fake' set but not used [-Werror,-Wunused-but-set-variable]
                bool tested_a_fake = false;

Describe the solution

Not totally sure what REQUIRE does, or if this is the right fix, but saw it was used like this in other places in the file 🤷

Describe alternatives you've considered

None

Testing

Compiles after change

Additional context

None

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Vehicles Vehicles, parts, mechanics & interactions json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 10, 2022
@kevingranade kevingranade merged commit f256820 into CleverRaven:master Jun 11, 2022
@Stephen2 Stephen2 deleted the sp-fix branch June 11, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. json-styled JSON lint passed, label assigned by github actions Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stephen2 @kevingranade