Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split permanent flag #58811

Merged
merged 6 commits into from
Aug 17, 2022
Merged

Split permanent flag #58811

merged 6 commits into from
Aug 17, 2022

Conversation

Maleclypse
Copy link
Member

@Maleclypse Maleclypse commented Jun 29, 2022 •
edited
Loading

Summary

None

Purpose of change

Adds an additional flag for item permanence no matter what the spell level is. This would allow some flexibility in the Mad Genius spell class in Xedra Evolved. Fixes #58719

Describe the solution

Cargo cults in magic.cpp and magic.h

Describe alternatives you've considered

None

Testing

TBD

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 29, 2022
@Maleclypse Maleclypse marked this pull request as ready for review June 30, 2022 00:06
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions and removed astyled astyled PR, label is assigned by github actions labels Jul 2, 2022
@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Aug 13, 2022
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Aug 17, 2022
@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Aug 17, 2022
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Aug 17, 2022
@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Aug 17, 2022
@dseguin dseguin merged commit 5d99290 into CleverRaven:master Aug 17, 2022
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 17, 2022
@Maleclypse Maleclypse deleted the Split-Permanent-Flag branch August 18, 2022 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KorGgenT KorGgenT Awaiting requested review from KorGgenT

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs stale Closed for lack of activity, but still valid.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split the spell's PERMANENT flag in two
2 participants
@Maleclypse @dseguin