Enable clang-tidy bugprone-redundant-branch-condition #58898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
NetSysFire
added
the
Code: Infrastructure / Style / Static Analysis
|
Sort-of unrelated but PRs touching .clang-tidy should get the Infrastructure label applied. |
github-actions
bot
added
the
BasicBuildPassed
|
|
jbytheway
force-pushed
the
clang-tidy_bugprone-redundant-branch-condition
branch
from
bd3fd32
to
23134f2
Compare
This check looks for conditions in if statements that are already guaranteed to be true due to earlier conditions.
jbytheway
force-pushed
the
clang-tidy_bugprone-redundant-branch-condition
branch
from
23134f2
to
efd362b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
More static analysis.
The
bugprone-redundant-branch-conditioncheck looks for conditions in if statements that are already guaranteed to be true due to earlier conditions.Describe the solution
Apply the automated fixes.
Describe alternatives you've considered
None.
Testing
I verified by eye that the conditions did indeed seem to be redundant.
Additional context