Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CrazyCataclysm] Fix mod's weight widget to overwrite the vanilla widget, add no_label variant #59272

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

mlange-42
Copy link
Contributor

Summary

Mods "Fix CrazyCataclysm weight widget to replace the vanilla version, add no_label variant"

Purpose of change

Make the CrazyCataclsym weight widget overwrite/replace the vanilla one.

The widget is not used anywhere explicitly, so we can assume that it is meant to replace/overwrite the vanilla widget (see #59229 (comment)). Also added a no_label version

Describe the solution

Changed widget id to weight_desc_label, added a version weight_desc_no_label

Describe alternatives you've considered

None

Testing

Created a world with mod CrazyCataclysm, tried sidebars that use the widget (modified one sidebar to also test the no_label variant)

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding labels Jul 14, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 14, 2022
@dseguin dseguin merged commit 69ab461 into CleverRaven:master Jul 15, 2022
@mlange-42 mlange-42 deleted the crazy-widget-overwrite branch July 17, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants