Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android builds #59415

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Fix Android builds #59415

merged 1 commit into from
Jul 19, 2022

Conversation

mqrause
Copy link
Contributor

@mqrause mqrause commented Jul 19, 2022

Summary

None

Purpose of change

Android builds don't fail.

Describe the solution

The error was caused by an oversight in #59065, so also replace that std::bind with a lambda.

Describe alternatives you've considered

Just adding the namespace for a fix that I'm 100% sure of will work.

Testing

I can't test this myself and CI also can't test this. So either someone else should test this or we all just hope for the best.
At least VS didn't complain about anything obvious.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 19, 2022
@dseguin dseguin merged commit 5301287 into CleverRaven:master Jul 19, 2022
@mqrause mqrause deleted the android_fix branch July 19, 2022 13:39
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants