Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand snippets on signs and graffiti #59602

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

anothersimulacrum
Copy link
Member

Summary

None

Purpose of change

Let people placing graffiti and signs use snippets.

Describe the solution

Expand snippets when applying tags.

Testing

Add a snippet (must be a snippet category that begins with < and ends with > (all expandable snippets)) to graffiti, see the graffiti spawn in the world with the snippet expanded.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 25, 2022
@dseguin dseguin merged commit caf6c5a into CleverRaven:master Jul 26, 2022
@LyranRenegade
Copy link
Contributor

Don't forget to also include the notes!
So we can make stuff like this work:

    {   
        "//": "3 variants of the same puzzle, 1 cryptic, 1 cryptic, other side, 1 for dummies, or just one for dummies",
        "type": "snippet",
        "category": "ha_snippet_mystery_note_squat",
        "text": [
            { 
                "id": "ha_squat_mystery_note_1", 
                "text": "A piece of paper with big letters written on it that say: \"<ha_given_name> I knew you would find this. Find me at <ha_squat_name>. There's a surprise underneath the section of RED carpet at the ground-floor in the hallway next to the toilet.\nLOVE, Cyrus\np.s. Sorry, I smoked your stash :)\""
            }
        ]
    },
    ```

@anothersimulacrum anothersimulacrum deleted the mapgen-snippets branch July 27, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants