Bugfix: Wrong column width with reused widget in last column #59816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comparison was against the id of the last widgets, which caused problems for widgets used multiple times. changed to iterate by index, and to use the index for the check.
github-actions
bot
added
<Bugfix>
mlange-42
changed the title
github-actions
bot
added
json-styled
dseguin
reviewed
Aug 1, 2022
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Wrong column width with reused widget as last one"
Purpose of change
Column widths could be wrong with
minimum_columnswhen a widget was used mutliple times in a layout, and one of the uses was the last column.Describe the solution
Layouts with
minimum_columnsremaining space to the last column.Comparison was against the Id of the last widgets, which caused problems for widgets used multiple times. Changed to iterate by index, and to use the index to check if it is the last widget.
Describe alternatives you've considered
None
Testing
Had a sidebar layout that was broken by the bug. It is fixed now.
Additional context
None