Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traits: update memory-based traits and bionics description #60237

Merged
merged 9 commits into from
Aug 28, 2022

Conversation

sonphantrung
Copy link
Contributor

@sonphantrung sonphantrung commented Aug 17, 2022

Summary

Bugfixes "traits: update memory-based traits and bionics description"

Purpose of change

As map memory is now permanent, the descriptions should be updated

Describe the solution

Updated the description, plus added comment about the fact that the JSON for map memory will be removed after 0.G Stable

Describe alternatives you've considered

Not doing this and keep seeing people getting confused

Testing

Should be good ;)

Additional context

Vormithrax on Discord brought me attention about this :)

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Bionics CBM (Compact Bionic Modules) <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels Aug 17, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 17, 2022
data/json/bionics.json Outdated Show resolved Hide resolved
data/json/mutations/mutations.json Outdated Show resolved Hide resolved
data/json/mutations/mutations.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` and removed json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 25, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Aug 26, 2022
@sonphantrung sonphantrung requested review from Fris0uman and removed request for KorGgenT August 26, 2022 04:26
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 26, 2022
@Fris0uman Fris0uman merged commit ab0c833 into CleverRaven:master Aug 28, 2022
@sonphantrung sonphantrung deleted the mmm branch August 28, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants