Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Add more variety to looks_like of magical herbs #60238

Merged

Conversation

pjf
Copy link
Contributor

@pjf pjf commented Aug 17, 2022

Summary

Mods "[Magiclysm] Added more variety to fallback tiles used for magical herbs"

Purpose of change

A lot of the herbs in Magiclysm looked like dandelions, which made it harder to identify them, and made magical meadows look like dandelion fields.

Describe the solution

Added more variety to looks_like for magical herbs:

  • Platonic flower -> bluebell
  • Moonflower -> datura
  • Kampuch -> burdock
  • Olieribos -> chicory
  • Glowing mushrooms -> glowing bulb
  • Moly -> Lotus
  • Flowering furn -> mutant poppy
  • Whiskflower -> dahlia

I've tried to keep these in-line with the item descriptions, and make sure that furniture uses furniture looks_like, and terrain uses terrain looks_like. (I don't know if this is needed or not)

I'm not attached to any of these changes in particular, I just wanted some variety.

Describe alternatives you've considered

None

Testing

Loaded a game saved in a magic meadow. Observed that it no longer appeared like a field of dandelions. Looked at a bunch of individual tiles to made sure the looks_like tiles matched the plant.

Additional context

Tagging in @GuardianDll for review/feedback

@pjf pjf requested a review from KorGgenT as a code owner August 17, 2022 07:08
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod json-styled JSON lint passed, label assigned by github actions labels Aug 17, 2022
@GuardianDll
Copy link
Member

I just didn't know what plants we have in the game :derpy:
Overall good job

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 17, 2022
@Rivet-the-Zombie Rivet-the-Zombie merged commit d652102 into CleverRaven:master Aug 18, 2022
@pjf pjf deleted the pull/magic_herbs_looks_like branch August 19, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants