Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix editmap derp #6028

Merged
merged 1 commit into from
Feb 9, 2014
Merged

Conversation

BevapDin
Copy link
Contributor

@BevapDin BevapDin commented Feb 8, 2014

This is a branch from atomicdryad, that fixes a serious bug in the overmap terrain debug menu. That bug prevents users from debugging things like the new dojo. Currently editmap uses the terrain list instead of the overmap terrain list. Because that terrain list is shorter it does not cause any crashes, but it hides many overmap terrains (.., dojo).

I didn't found this, atomicdryad did. He/she should be complimented, but I thinks this should really go into the mainline. I don't know the policy of those things, so please excuse me if this is the wrong way to handle it.

@KA101
Copy link
Contributor

KA101 commented Feb 8, 2014

AtomicDryad was talking about leaving the project a while back, and hasn't been around since. If she wants that pushed here, so be it. (I'm sure we'll all be glad for her return, too.) If she hasn't said anything about it, then perhaps best to leave it. Sorry.

@BevapDin
Copy link
Contributor Author

BevapDin commented Feb 8, 2014

But this is a bug. It should be fixed. Can't you just insert those tow characters into the file yourself?

@kevingranade
Copy link
Member

All contributions are covered by CC-BY-SA, which means we can pull from any other repository freely as long as we conserve attribution (which you did, thanks). It's the whole point of a copyleft license.
tl;dr I'll definitely be considering this for inclusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants