Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kitchen Cleaver(s) damage adjustment #60467

Merged
merged 2 commits into from
Sep 3, 2022

Conversation

lightinthefog
Copy link
Contributor

changing values of bash/cut damage for both items.

Summary

Balance "Changing meat/vegetable cleaver damage values"

Purpose of change

Fixes #60404.

Describe the solution

Vegetable cleaver damage has been lowered, and meat's raised, to align with in-game descriptions.

Describe alternatives you've considered

Maybe the numbers are too tuned, but I'm not sure.

Testing

Values are as changed in-game.

Additional context

changing values of bash/cut damage for both items.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 26, 2022
@Maleclypse
Copy link
Member

You'll have to adjust the dps test as cleaver has an expected range outside of your changes.

> expected weapon dps
(~[slow] ~[.],starting_items)=>   knives
(~[slow] ~[.],starting_items)=> -------------------------------------------------------------------------------
(~[slow] ~[.],starting_items)=> ../tests/effective_dps_test.cpp:518
(~[slow] ~[.],starting_items)=> ...............................................................................
(~[slow] ~[.],starting_items)=> 
(~[slow] ~[.],starting_items)=> ../tests/effective_dps_test.cpp:532: FAILED:
(~[slow] ~[.],starting_items)=>   CHECK( calc_expected_dps( "knife_meat_cleaver" ) == 11.54 )

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. <Bugfix> This is a fix for a bug (or closes open issue) BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 28, 2022
@bombasticSlacks bombasticSlacks merged commit 9c0cfea into CleverRaven:master Sep 3, 2022
@lightinthefog lightinthefog deleted the cleaverfix branch September 3, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vegetable cleaver is slightly better than the meat cleaver, despite it’s description saying the contrary.
3 participants