New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retractable "3D" sprites for walls etc. #60471
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
Changes (can be) made in C++. Previously named `Code`
[Python]
Code made in Python
Code: Tooling
Tooling that is not part of the main game but is part of the repo.
Info / User Interface
Game - player communication, menus, etc.
astyled
astyled PR, label is assigned by github actions
labels
Aug 26, 2022
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Aug 26, 2022
BevapDin
reviewed
Aug 27, 2022
mlange-42
force-pushed
the
toggle-iso-height
branch
from
August 27, 2022 18:28
edd6d83
to
8fcc4e5
Compare
Co-authored-by: BevapDin <tho_ki@gmx.de>
mlange-42
force-pushed
the
toggle-iso-height
branch
from
August 29, 2022 17:15
8fcc4e5
to
60b6874
Compare
Rebased to resolve conflicts after #60283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
[C++]
Changes (can be) made in C++. Previously named `Code`
Code: Tooling
Tooling that is not part of the main game but is part of the repo.
Info / User Interface
Game - player communication, menus, etc.
json-styled
JSON lint passed, label assigned by github actions
[Python]
Code made in Python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Retractable '3D' sprites for walls etc."
Purpose of change
Upcoming isometric tilesets offer the opportunity for a more 3-dimensional look. For a consistent perspective across terrain, furniture and monsters, walls need to have a certain height. Orthogonal tilesets could also profit from higher walls for a more consistent perspective.
3D walls, however, will obstruct other terrain, etc.:
Courtesy tileset: UlticaISO by @vetall812
This PR tries to resolve this conflict and adds the ability to change/toggle wall height using a mapped key (see GIFs below).
Describe the solution
Things to note:
Describe alternatives you've considered
Testing
compose.py
with UlticaISO (thanks @vetall812)Additional context
GIFs showing the toggle using a key binding.
Courtesy tileset: UlticaISO by @vetall812