Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mi-go guardians moving away from its tower #60474

Merged
merged 4 commits into from Aug 28, 2022

Conversation

Marcos6226
Copy link
Contributor

@Marcos6226 Marcos6226 commented Aug 27, 2022

Summary

Bugfixes "Fix mi-go guardians moving too far away from its tower."

Purpose of change

This PR should fix #59545

Steps to reproduce the bug and see if it's fixed:

  1. Find or spawn a mi-go tower.
  2. Aggro a mi-go guardian to pursue you.
  3. Check if it will not follow you to the end of the world.

Describe the solution

Based on the issue comments, I have decided to heed the suggestion of adding a "patrol": line. But the format present does not permit this so I modified it to be similar of the PR mentioned on the comments. Thanks LyleSY!

Describe alternatives you've considered

I'm not really sure if this is the best solution ever to this problem (my first time messing with mapgen) but, as always, I'm open to any suggestions.

Testing

I have spawned a mi-go scout tower and aggroed some guards to follow me. They will pursue me, but after some distance (or after I break the line-of-sight), they will stop following me and return to their base, as expected.

Additional context

None

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels Aug 27, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 27, 2022
@Venera3
Copy link
Contributor

Venera3 commented Aug 27, 2022

This will have them return to that one spot the moment you break eye contact - I suggest setting up a patrol route around the base, that'll keep them from being too dumb. The patrol routes can deal with coords outside of the mapgen in question as well, so you can even set them to patrol the neighboring tiles.

@Marcos6226
Copy link
Contributor Author

This will have them return to that one spot the moment you break eye contact - I suggest setting up a patrol route around the base, that'll keep them from being too dumb. The patrol routes can deal with coords outside of the mapgen in question as well, so you can even set them to patrol the neighboring tiles.

Done, thanks for the help.

@dseguin dseguin merged commit 84096a5 into CleverRaven:master Aug 28, 2022
@Marcos6226 Marcos6226 deleted the mi-go-guard-fix branch August 28, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mi-go guardian should not move away from his tower.
4 participants