Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M2 carbine fixes #60694

Merged
merged 6 commits into from
Sep 3, 2022
Merged

Conversation

DPavonis
Copy link
Contributor

@DPavonis DPavonis commented Sep 2, 2022

Summary

Bugfixes "The M2 carbine can now fire in full-auto as intended"

Purpose of change

Allows the M2 carbine to fire in full auto,

Describe the solution

Replaced most of the M2 carbine's definition with "copy-from": "m1carbine", and added in the missing "modes" field

Describe alternatives you've considered

Testing

Booted up the game, debug spawned in an M2, made sure it could switch fire modes.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 2, 2022
@bombasticSlacks bombasticSlacks merged commit 508a406 into CleverRaven:master Sep 3, 2022
@DPavonis DPavonis deleted the M2-carbine-fixes branch February 5, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants