Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit coat rack components to include long stick #61075

Merged
merged 3 commits into from
Sep 21, 2022
Merged

Edit coat rack components to include long stick #61075

merged 3 commits into from
Sep 21, 2022

Conversation

AirRice
Copy link
Contributor

@AirRice AirRice commented Sep 17, 2022

Summary

Balance "Edit coat rack components to include long stick"

Purpose of change

The ingame description for the furniture item "coat rack" states, and I quote:

"A tall wooden pole with a set of hooks used to store outdoor jackets and hats to allow easy access."

Before this proposed change deconstructing a coat rack provided two 2x4 planks. However, it makes sense to me that such a furniture item, when deconstructed, would provide a long and sturdy enough pole or stick that can be used for crafting purposes.

Describe the solution

Edit the deconstruction recipe of the coat rack furniture item (ID: f_rack_coat) to provide:

  • BEFORE: 2~6 nails, 2 planks
  • AFTER: 2~6 nails, 1 plank, 1 long stick
    image

Additionally, edit the construction recipe of the coat rack furniture item for consistency:

  • BEFORE: 8 nails, 3 planks
  • AFTER: 8 nails, 2 planks, 1 long stick
    image

The products from smashing the furniture has not been changed, as it would make sense for forcefully smashing apart a coat rack to break the long pole part of it to be unusable.

Describe alternatives you've considered

Do not make this change. Make the coat rack provide heavy sticks, long poles (would be insanely OP), or some other long wooden component instead.

Testing

  1. Spawn in the world.
  2. Use the debug menu to spawn in coat rack furniture (ID: f_rack_coat) and the necessary tools for deconstructing it (1 prying, 1 screw driving qualities)
  3. Deconstruct the coat rack and observe that it provides the expected components as seen above.
  4. Look in the construction menu (default hotkey *) and check that the coat rack recipe is changed as seen above.

Additional context

This is my first PR and while it is quite rudimentary I hope to contribute more in the future :)

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Containers Things that hold other things Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions labels Sep 17, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 21, 2022
@Fris0uman Fris0uman merged commit 7c17d7b into CleverRaven:master Sep 21, 2022
@jeffplata
Copy link

Nice change :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Game: Balance Balancing of (existing) in-game features. Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants