Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "mana frame" part from install UI #61112

Merged
merged 1 commit into from
Sep 18, 2022

Conversation

irwiss
Copy link
Contributor

@irwiss irwiss commented Sep 18, 2022

Summary

None

Purpose of change

Fixes #43364

Describe the solution

In #59563 I made OBSOLETE flag hide parts from install UI.

Use said flag to hide "mana frame".

Also removes INITIAL_PART on it as it is not relevant to summoned vehicles - it's only used for part filter for constructing vehicles from scratch.

Describe alternatives you've considered

Testing

Use the steps in linked issue, mana frame should not appear in parts list for install.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions labels Sep 18, 2022
@irwiss irwiss marked this pull request as ready for review September 18, 2022 22:54
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 18, 2022
@dseguin dseguin merged commit 6b3eb71 into CleverRaven:master Sep 18, 2022
@irwiss irwiss deleted the hide-mana-frame branch September 18, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Magiclysm] Part that we cannot make or get "mana frame"
2 participants