Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nerf finding kitten to level of music enjoyment #61429

Merged
merged 1 commit into from
Oct 5, 2022
Merged

nerf finding kitten to level of music enjoyment #61429

merged 1 commit into from
Oct 5, 2022

Conversation

l29ah
Copy link
Contributor

@l29ah l29ah commented Oct 3, 2022

Summary

Balance "nerf finding kitten to level of music enjoyment"

Purpose of change

fixes #61420

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Oct 3, 2022
@andrei8l
Copy link
Contributor

andrei8l commented Oct 3, 2022

You need to find the kitten to get that bonus. That is, play the game that has been bringing boundless joy since 1997. 30 is possibly too low.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Oct 3, 2022
anothersimulacrum
anothersimulacrum reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@anothersimulacrum anothersimulacrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of these other games also give 30, don't just unfairly nerf robot finds kitten!

@l29ah
Copy link
Contributor Author

l29ah commented Oct 3, 2022

Some of these other games also give 30, don't just unfairly nerf robot finds kitten!

Only the kitten gives any morale buff, it's special-cased by the caller.

@Rivet-the-Zombie Rivet-the-Zombie merged commit 81e1caf into CleverRaven:master Oct 5, 2022
@omni-Var
Copy link

omni-Var commented Oct 5, 2022 •
edited
Loading

Shouldn't boons that require active input from the user (to second Andrei8l's point) assess a stronger buff? Looking for objections to not make a PR to re-tune it up, somewhat, again.

@l29ah
Copy link
Contributor Author

l29ah commented Oct 5, 2022

Do you suggest incentivizing micromanagement?

@omni-Var
Copy link

omni-Var commented Oct 5, 2022

Do you suggest removing all reward for additional investment? I didn't hear anyone complaining about this one.

@l29ah
Copy link
Contributor Author

l29ah commented Oct 5, 2022

Press x 1000 times to get a morale boost with no in-game time expense.

@CleverRaven CleverRaven locked as resolved and limited conversation to collaborators Oct 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anothersimulacrum anothersimulacrum anothersimulacrum left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"robot loves kitten" mood buff is far too high.
5 participants
@l29ah @andrei8l @omni-Var @anothersimulacrum @Rivet-the-Zombie