Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mr 73 high end revolver #61564

Merged
merged 13 commits into from
Oct 21, 2022
Merged

Conversation

nopenoperson
Copy link
Contributor

@nopenoperson nopenoperson commented Oct 9, 2022

Summary

Content "rare high end .357 revolver"

Purpose of change

the game has 0 six shot revolvers in 357 magnum so i wanted to add one

Describe the solution

did a bunch of research online and some calculations then put the stuff in 38.json. used .38 as a template for the nested ammo stuff. they are tested to shoot atleast 2.8 moa before leaving the factory so i gave it 280 dispersion. these things are supposed to hold up to constant horrible abuse day after day for years so 10 reliability .

Describe alternatives you've considered

making it more or less accurate. spending more time figuring out volume. asking for advice on item groups. not making this pr

Testing

yes its a revolver that has good dispersion and the correct speedloader works. its very potent with the weaker 38 ammo because of the synergy that the great dispersion has with lower recoil ammo but you only have 6 shots so it doesnt really get out of hand
the complicated nested ammo thingy works pretty well and if you make the json entry simpler, it doesnt produce very good results in my testing

Additional context

@nopenoperson nopenoperson changed the title Nopenoperson mr73 mr 73 high end revolver Oct 9, 2022
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Spawn Creatures, items, vehicles, locations appearing on map labels Oct 9, 2022
Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Oct 9, 2022
@github-actions github-actions bot added Mods Issues related to mods or modding Mods: Generic Guns Anything to do with Generic Guns labels Oct 9, 2022
@tenmillimaster
Copy link
Member

Looks like the rarity is about right . I compared it to the raging bull in 454 and BFR in 45-70.

I suggest adding .38 special to the on hand, 357 mag ammo item group.

I question the mod locations this has available, but that's a problem with most guns.

@nopenoperson
Copy link
Contributor Author

I suggest adding .38 special to the on hand, 357 mag ammo item group.
you can type out out what you think it should be as suggestion if you feel like it

@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Oct 9, 2022
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 9, 2022
Copy link
Member

@tenmillimaster tenmillimaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the mod location comments.

data/json/items/gun/38.json Outdated Show resolved Hide resolved
data/json/items/gun/38.json Outdated Show resolved Hide resolved
data/json/items/gun/38.json Outdated Show resolved Hide resolved
Copy link
Member

@tenmillimaster tenmillimaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dseguin dseguin merged commit 63ed2c9 into CleverRaven:master Oct 21, 2022
@nopenoperson nopenoperson deleted the nopenoperson-mr73 branch October 21, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Generic Guns Anything to do with Generic Guns Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants