Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give Sadie more survival options. #61795

Merged
merged 2 commits into from
Oct 22, 2022
Merged

Give Sadie more survival options. #61795

merged 2 commits into from
Oct 22, 2022

Conversation

KymasTuran
Copy link
Contributor

Summary

Balance "Brief description"

Add some bionic to show why she is not starving or dead, also she is more badass now.

Purpose of change

Fun

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@KymasTuran
Update classes.json
06e1929 
Give Sadie more survival options. Its supposed she as been without food for some time but she is fine so I add some bionic to show why. Also she is more badass.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Aftershock Anything to do with the Aftershock mod NPC / Factions NPCs, AI, Speech, Factions, Ownership Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions labels Oct 19, 2022
@Maleclypse
Copy link
Member

https://dev.narc.ro/cataclysm/format.html needs linting to be easier to review

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Oct 19, 2022
@Zireael07
Copy link
Contributor

IIRC bionics are slowly being phased out of the main game, no?

@MNG-cataclysm
Copy link
Contributor

IIRC bionics are slowly being phased out of the main game, no?

No, the source for bionics is being changed. This is for a mod.

LyleSY
LyleSY approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@LyleSY LyleSY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely fits the spirit of the content

@KymasTuran
Copy link
Contributor Author

Definitely fits the spirit of the content

Thanks. Is one of my favorite NPC and I did a lot of edit on this one. I also add an option in is dialogue using is bio (cant find a better way) so I can ask for another injection. But even after "linting" both files still show red flags :p the other is for more deactivated robots for jury rig them later.

@ZhilkinSerg ZhilkinSerg merged commit 4e65b33 into CleverRaven:master Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LyleSY LyleSY LyleSY approved these changes

@Maleclypse Maleclypse Awaiting requested review from Maleclypse

@John-Candlebury John-Candlebury Awaiting requested review from John-Candlebury

@Mom-Bun Mom-Bun Awaiting requested review from Mom-Bun

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KymasTuran @Maleclypse @Zireael07 @MNG-cataclysm @LyleSY @ZhilkinSerg