Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Player cannot handle gasses like solids"
Purpose of change
Closes #61605
Describe the solution
This prevents the player from doing the following with uncontained gasses: Picking up, consuming, wielding, moving with AIM (either individually or with move all), hauling, or loot zone sorting. Ugh
All existing gasses that I found with grep had
NO_DROP
added, this will cause them to vanish(be destroyed) if they should ever find themselves outside a container. But just in case they don't, or new gasses are added withoutNO_DROP
... the player should not be able to interact with them in any untoward ways.Describe alternatives you've considered
Making an item with
PHASE_ID::GAS
instantly be destroyed when uncontained, as if they all hadNO_DROP
flagged. Decided against it because I already had enough fun looking through functions and testing.Testing
Compiled locally each step of the way and confirmed the changes function as advertised. Spawned in all the items and made some acetlyene (a
NO_DROP
item), then further crafted it into oxyacetlyene, confirmed I was able.Additional context