Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed NPC's dropping integrated weapons on death #62118

Merged

Conversation

azalahli
Copy link
Contributor

@azalahli azalahli commented Nov 7, 2022

Summary

Bugfixes "Added integrated flag to NPC die() check for weapons"

Purpose of change

Fixes #61832

Describe the solution

Added the integrated flag to the check for the weapon drop, which is apparently handled differently from the rest of the inventory.

Describe alternatives you've considered

There is some confusion over the usage of the NO_UNWIELD and INTEGRATED tags, mostly based on if it is bionic or not?
If bionics.json or integrated.json all harmonized tags it should have a similar effect.

Testing

Spawn an NPC -> Randomize NPC class to Apis -> Kill Apis
Be advised that the bug will only occur if the Apis is armed with the claws. (So ensure that the Apis has no better weapon, and is hostile)
Tested the final killing once, after creating a save which would reliably drop the claws on death

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) labels Nov 7, 2022
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 7, 2022
@Fris0uman Fris0uman merged commit 4852b20 into CleverRaven:master Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apis drop integrated sclerotin claws
2 participants