-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes for NPC death to portal storms #62465
fixes for NPC death to portal storms #62465
Conversation
Just out of interest, what would happen if you took a follower with you into a portal storm dungeon? Would they also get teleported back from it when PS ends? |
I'm not sure mechanically how portal storms interact with followers. They should no longer get slaughtered outside |
What's the intended "lore" reason for this? Are portal storms "attracted" to intelligent life, higher level thought? Sort of related to the principle of the netherum being shaped by human thought I assume. |
The lore reason is that we can't write AI for this for a long while. Or perhaps intelligence and imagination is necessary for the Netherum to work |
Summary
None
Purpose of change
fixes #58023
Describe the solution
This PR does two things.
First for the base game, portal storm entities now ignore animals, and vice versa. This is something that needs to happen for the core game to make sense. Otherwise after the first few portal storm giant appendages will have killed every living animal on earth leaving only zombified ones. Even if portal storms are localized this still puts much too tight of a timeline on all non humans being dead.
Second to fix the consistent issue of NPC death I've added a new on by default mod that makes portal storm enemies passive to NPCs, and in tested cases vice versa. This isn't a perfect solution but to get .G out and not have huge problems I think it is a workable solution for now. It also allows people to disable it if they want the non easy mode version too.
Describe alternatives you've considered
Discussed to death, people will keep plugging away.
Testing
Enable mod, turn on debug stuff to be invisible, stand in the refugee center, start a portal storm, wait around.
Additional context