Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for NPC death to portal storms #62465

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

bombasticSlacks
Copy link
Contributor

@bombasticSlacks bombasticSlacks commented Nov 29, 2022

Summary

None

Purpose of change

fixes #58023

Describe the solution

This PR does two things.

First for the base game, portal storm entities now ignore animals, and vice versa. This is something that needs to happen for the core game to make sense. Otherwise after the first few portal storm giant appendages will have killed every living animal on earth leaving only zombified ones. Even if portal storms are localized this still puts much too tight of a timeline on all non humans being dead.

Second to fix the consistent issue of NPC death I've added a new on by default mod that makes portal storm enemies passive to NPCs, and in tested cases vice versa. This isn't a perfect solution but to get .G out and not have huge problems I think it is a workable solution for now. It also allows people to disable it if they want the non easy mode version too.

Describe alternatives you've considered

Discussed to death, people will keep plugging away.

Testing

Enable mod, turn on debug stuff to be invisible, stand in the refugee center, start a portal storm, wait around.

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions labels Nov 29, 2022
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Nov 29, 2022
@DSeyka
Copy link
Contributor

DSeyka commented Nov 29, 2022

Just out of interest, what would happen if you took a follower with you into a portal storm dungeon? Would they also get teleported back from it when PS ends?
The reason I'm asking this here is because I feel this change will make it much more feasible for them to survive the trip; previously they'd likely get slaughtered very quickly outside.

@bombasticSlacks
Copy link
Contributor Author

I'm not sure mechanically how portal storms interact with followers. They should no longer get slaughtered outside

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 29, 2022
@I-am-Erk I-am-Erk merged commit c299253 into CleverRaven:master Nov 29, 2022
@anoobindisguise
Copy link
Contributor

What's the intended "lore" reason for this? Are portal storms "attracted" to intelligent life, higher level thought? Sort of related to the principle of the netherum being shaped by human thought I assume.

@I-am-Erk
Copy link
Member

The lore reason is that we can't write AI for this for a long while. Or perhaps intelligence and imagination is necessary for the Netherum to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Important Faction NPCs not immune to portal storms
4 participants