Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPC putting items in open air when fetching items during an activity when 3D FOV is on #66337

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

Qrox
Copy link
Contributor

@Qrox Qrox commented Jun 20, 2023

Summary

Bugfixes "Fix NPC putting items in open air when fetching items during an activity when 3D FOV is on"

Purpose of change

Once our slaves builders discover the sky they invent juggling and throw items into the air instead of placing them on the same z-level as the target tile. This PR makes NPCs do the latter instead.

Describe the solution

Only check tiles on the same z-level as the target tile when looking for tile to place items.

Describe alternatives you've considered

None

Testing

  1. Enable 3D FOV
  2. Create construction zone one tile south of the player
  3. Create unsorted loot zone 13 tiles north of the player and place needed construction materials and tools there
  4. Teleport an follower to the player's location and let them do construction
  5. Before this change, NPC walks to the loot zone and places items in an open air tile above the construction zone
  6. Before this change, the unit test hangs when testing construction activity
  7. After this change, NPC places items near the construction zone on the same z-level
  8. After this change, the unit test no long hangs (although it still fails due to another error)

Additional context

None

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 20, 2023
@dseguin dseguin merged commit 249579b into CleverRaven:master Jun 21, 2023
@Qrox Qrox deleted the work-not-juggle branch June 21, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants