Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counter gate move cost #66429

Merged
merged 2 commits into from
Jul 1, 2023
Merged

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Jun 24, 2023

Summary

Bugfixes "Open counter gates are faster to navigate than counters"

Purpose of change

Partially addresses #66423

Describe the solution

Open counter gate now has no move cost penalty over the base terrain

Describe alternatives you've considered

Making the closed gate -10 mod instead but them it says "Impassable" which doesn't make much sense so I just moved it in line with the open gate

Making it 1 move cost mod instead but as it is now with opening taking 100 it still takes about the same to open and move through the gate as going over the counter so 0 move cost mod seems to make more sense

Giving counter gates the ability to be examine climbed for the same movecost as navigating the regular counter but the only climb action costs 400 and I don't fancy making a c++ change for something so minor

I looked at counters and cupboards because they have kind of odd similarities/differences but I couldn't decide what to do with them so I left them as is

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 24, 2023
@Demivan
Copy link
Contributor

Demivan commented Jun 24, 2023

It is a good addition, but it does not fully solve #66423. I think it is better to keep the issue open.

@Procyonae Procyonae marked this pull request as draft June 24, 2023 17:39
@Procyonae Procyonae marked this pull request as ready for review June 24, 2023 18:50
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 24, 2023
@Maleclypse Maleclypse merged commit 2386ec2 into CleverRaven:master Jul 1, 2023
22 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants