Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOC Run Until #66449

Merged
merged 4 commits into from
Jul 2, 2023
Merged

EOC Run Until #66449

merged 4 commits into from
Jul 2, 2023

Conversation

bombasticSlacks
Copy link
Contributor

Summary

Infrastructure "EOC run until"

Purpose of change

Wanted to be able to call an EOC multiple times without creating a massive call stack, seemed messy and inefficient.

Describe the solution

Adds new call eoc_run_until
you provide the name of a condition in the current context and an EOC and it runs it until the condition is false.

Describe alternatives you've considered

Testing

Unit test included.

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON [Markdown] Markdown issues and PRs Code: Tests Measurement, self-control, statistics, balancing. NPC / Factions NPCs, AI, Speech, Factions, Ownership Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jun 25, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 29, 2023
@dseguin dseguin merged commit 6c5ffff into CleverRaven:master Jul 2, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrei8l andrei8l andrei8l left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style Code: Tests Measurement, self-control, statistics, balancing. <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bombasticSlacks @andrei8l @dseguin