Add more generic_factory checks to vpart_info loader #66450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
irwiss
changed the title
irwiss
changed the title
irwiss
force-pushed
the
vpart-factory-checks
branch
from
2f7f401
to
5d15565
Compare
NetSysFire
added
the
Code: Infrastructure / Style / Static Analysis
irwiss
force-pushed
the
vpart-factory-checks
branch
3 times, most recently
from
1b5e5e9
to
b07ead8
Compare
github-actions
bot
added
the
BasicBuildPassed
irwiss
force-pushed
the
vpart-factory-checks
branch
from
b07ead8
to
4840a25
Compare
hexagonrecursion
added a commit
to hexagonrecursion/Cataclysm-DDA
that referenced
this pull request
Jun 29, 2023
```
DEBUG : (json-error)
Json error: data/json/vehicleparts/doors.json:106:16: cannot assign explicit value the same as default or inherited value
"description": "A strong door. Solid construction means you can't see through it when closed.",
"durability": 660,
"location":
^
"center",
"looks_like": "door_opaque",
"name": { "str": "heavy-duty opaque door" },
FUNCTION : void report_strict_violation(const JsonObject&, const string&, std::string_view)
FILE : src/assign.cpp
LINE : 11
VERSION : 5820766
```
Ref: CleverRaven#66450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Use more generic_factory features in vpart_info loader
Describe the solution
Add strict checking on most vpart_info fields when src=="dda"
Change install/repair etc time to use time_duration - just the serialization parts for now
Cleanup and merge the loader into one function
Move the loose VPFLAG comments to vp_flags.json
Remove ROTOR_SIMPLE flag
Remove undocumented and unused feature on loader (array length 1 skill loading)
Describe alternatives you've considered
Testing
Tested via dumping vpart_info to file 38a1fc9
Additional context