Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for first hub mission & more gear for Dr.Prado #66458

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

casswedson
Copy link
Contributor

Summary

None

Purpose of change

a while back I ran into this rare error involving sunflowers and dirt; get rid as the game suggest, add a flag to remove all that's there before placing our custom mapgen

also add a little more loot to Dr. Prado the woman killed by the hub prototype robot you take care of in the first mission add some paper, writing utensils and a laptop for the report she's probably making
a little water, sunglasses and gum - damage the spawned items, the murder bot presumably trashed the gear

the error message:
Screenshot from 2023-05-14 15-01-36

Describe the solution

Describe alternatives you've considered

Testing

sample
Screenshot from 2023-06-25 13-57-10

Additional context

a while back I ran into this rare error involving sunflowers and dirt;
get rid as the game suggest, add a flag to remove all that's there
before placing our custom mapgen

also add a little more loot to Dr. Prado the woman killed by the hub
prototype robot you take care of in the first mission
add some paper, writing utensils and a laptop for the report she's
probably making
a little water, sunglasses and gum - damage the spawned items, the
murder bot presumably trashed the gear
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Missions Quests and missions astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 25, 2023
@KHeket
Copy link
Contributor

KHeket commented Jun 26, 2023

May be also add at least modular headgear with prototype helmet to the dead body drop? Because, if the prototype greaves and vambraces can be obtained via dialog with intercom, the prototype helmet is unabtainable, and it is very big pain to buy modular headgear, the intercome sometimes just dont have it for mounths. It will be also logical freindly - torso and head are most vital parts, rather than legs and arms

@John-Candlebury
Copy link
Member

May be also add at least modular headgear with prototype helmet to the dead body drop? Because, if the prototype greaves and vambraces can be obtained via dialog with intercom, the prototype helmet is unabtainable, and it is very big pain to buy modular headgear, the intercome sometimes just dont have it for mounths. It will be also logical freindly - torso and head are most vital parts, rather than legs and arms

Lack of headgear is intentional, it should be introduced with other questlines.

@Maleclypse
Copy link
Member

Reset tests.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions and removed json-styled JSON lint passed, label assigned by github actions labels Jul 2, 2023
@Maleclypse Maleclypse merged commit 10875c2 into CleverRaven:master Jul 3, 2023
23 checks passed
@casswedson casswedson deleted the add-flag-char-dev branch July 3, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants