Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone case variants, to infinity, and beyond. #66462

Merged
merged 6 commits into from
Jul 3, 2023

Conversation

DoctorBoomstick
Copy link
Contributor

Summary

Content "adds multiple boatloads of new phone case variants, based, mostly, around different horror movies."

Purpose of change

Creating this PR on behalf of Cosmic on the discord, with 99% of the variants here being totally their work. Variants are fun, cool, and interesting, and this PR simply adds more for the sake of building up those numbers.

Describe the solution

This simply adds a whole cinema’s worth of horror-themed phone cases to the already existing variants, with all themed cases balanced to have a much lower spawn chance than their plainly colored brethren.
I placed this PR as a draft as both I and Cosmic are minorly iffy on the acceptability of including name-dropping content within CDDA, lest the armies of copyright lawyers be heard on the march, and figured it would be prudent to place the changes as a draft to see the general consensus and if changes ought to be made.

Describe alternatives you've considered

Going to bed rather than including Xenomorph phone cases in cdda. Unacceptable.

Testing

They simply slot into the existing variants structure, and no syntax errors were reported in the process of linting.

Additional context

See, almost every single horror movie created for context. It might take a while.

…s which will devower the world and plunge it into a kingdom of phone cases by sheer numbers. cases. cases. cases. dear god, so many cases.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Containers Things that hold other things astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jun 26, 2023
@github-actions
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • This design is inspired by the Necronomicon and the demonic beings it awakens, as well as the hero from the 'Evil Dead' horror-comedy series. The case features the book's cover design in brown with raised lettering. The lettering represents the ancient text of the book; however, the iconical silhouette of Ash Williams can be seen in the center, with text saying 'Hail to the King, baby'.
  • This waterproof smartphone case features a dark design with a graphic of fingers taped up and blood dripping from them. The case's sidewalls double as barbed wire or chains, adding contextual depth.
  • This waterproof smartphone case features a graphic of a blindfolded face on a black background with subtle patterns in the wallpaper. The sidewalls have a broken, abstract hue with some light elements and waves.
  • This waterproof smartphone case features a graphic of a creepy motel sign that can become warm and soothing with a touch of nostalgia for the old times. The sidewalls feature floral patterns serenading the hotel's name.
  • This waterproof smartphone case features a graphic of a galaxy with stars, planets, and a dark looming force in its center, giving an ode to the movie's intriguing cosmic horror. The sidewalls incorporate a similar starry design with abstract waves.
  • This waterproof smartphone case features a graphic of a giant plant with monster-like tendrils wrapped in gritty textures and faded imagery in the background. The sidewalls resemble the stems of a giant plant with somewhat abstract foliage.
  • This waterproof smartphone case features a graphic of a metallic surface with red and silver colors and subtle tendrils interwoven around it, giving a nod to the movie's titular villain. The sidewalls resemble veins through a similar design.
  • This waterproof smartphone case features a graphic of a sinister fog with an iconic pyramid-headed silhouette in a dark world. The sidewalls evoke an intermittent window pattern with the world's colors moving over it.
  • This waterproof smartphone case features a graphic of a white, ominous cloud over a suburban environment at night with tree branches and lightning in the background. The sidewalls include misty abstract elements and tree graphics.
  • This waterproof smartphone case features a graphic of black and white mixed with static running through a dark background with fog and trees. You can see the mysterious figure of the pale, faceless stalker among those trees. The sidewalls resemble trees, with the same static running through them.
  • This waterproof smartphone case features a graphic of icebergs floating in the ocean with a cracked blue texture, giving a hint to the movie's overall environment. The sidewalls include weather-related graphics, such as lightning and clouds.
  • This waterproof smartphone case features a graphic of modern high-rise buildings sinking in floodwater with a dark and gloomy blue and green color palette. The sidewalls evoke the same colors in a pattern resembling the water's flow.
  • This waterproof smartphone case features a graphic of the Ouija board, with the film's title at the bottom, and a spooky blue-grey color throughout, symbolizing the film's eeriness and supernatural horror.
  • This waterproof smartphone case features a graphic of zombie silhouettes in a comic-style format on a black background. The sidewalls include a subtle 'blood effect' graphic, along with design elements of basic, mundane everyday objects recently used as weapons.
  • This waterproof smartphone case features an image of a classic gothic castle with a sinister font in tones of blood red, deep black, and gothic elements. The sidewalls resemble the stone-walled interiors of the same castle, with colors matching the dominant colors of the case.
  • This waterproof smartphone case features an image of a creepy tooth fairy with sharp, acidic white accents on a dark black background. The sidewalls include personal toothbrush elements.
  • This waterproof smartphone case features an image of a toxic green zombie hand with a graphic resembling the weapon attached to Cherry's stump in the movie. The sidewalls are deep red, with blood-effect splatters on top of them.
  • This waterproof smartphone case features an image of an extraterrestrial spacecraft hovering over a city at night with intricate details resembling the craft from the movie. The sidewalls include graphics of the solar system and other space motifs.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

data/json/items/containers.json Outdated Show resolved Hide resolved
data/json/items/containers.json Outdated Show resolved Hide resolved
DoctorBoomstick and others added 2 commits June 26, 2023 16:17
Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com>
Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com>
@Procyonae
Copy link
Contributor

Why have you removed waterproof from the names?

@DoctorBoomstick
Copy link
Contributor Author

Why have you removed waterproof from the names?

I felt like the names became way, way, way too wordy and giant on most of them when “waterproof” was included in the name. we don’t have any non-water proof cases currently in game, so mentioning that element in the name is, in my view, rather redundant. Plus, from what I’ve read as I was doing some grammer checks on them, most of the descriptions state that they’re water proof anyhow.

@Procyonae
Copy link
Contributor

I felt like the names became way, way, way too wordy and giant on most of them when “waterproof” was included in the name. we don’t have any non-water proof cases currently in game, so mentioning that element in the name is, in my view, rather redundant. Plus, from what I’ve read as I was doing some grammer checks on them, most of the descriptions state that they’re water proof anyhow.

Fair enough

data/json/items/containers.json Outdated Show resolved Hide resolved
data/json/items/containers.json Outdated Show resolved Hide resolved
data/json/items/containers.json Outdated Show resolved Hide resolved
DoctorBoomstick and others added 3 commits June 28, 2023 13:32
Co-authored-by: Procyonae <45432782+Procyonae@users.noreply.github.com>
Co-authored-by: Procyonae <45432782+Procyonae@users.noreply.github.com>
Co-authored-by: Procyonae <45432782+Procyonae@users.noreply.github.com>
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jun 28, 2023
@Maleclypse
Copy link
Member

Is this ready for review?

@DoctorBoomstick DoctorBoomstick marked this pull request as ready for review July 3, 2023 07:35
@Maleclypse Maleclypse merged commit 5b306ad into CleverRaven:master Jul 3, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Containers Things that hold other things [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants