-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phone case variants, to infinity, and beyond. #66462
Conversation
…s which will devower the world and plunge it into a kingdom of phone cases by sheer numbers. cases. cases. cases. dear god, so many cases.
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com>
Co-authored-by: TheShadowFerret <99621099+TheShadowFerret@users.noreply.github.com>
Why have you removed waterproof from the names? |
I felt like the names became way, way, way too wordy and giant on most of them when “waterproof” was included in the name. we don’t have any non-water proof cases currently in game, so mentioning that element in the name is, in my view, rather redundant. Plus, from what I’ve read as I was doing some grammer checks on them, most of the descriptions state that they’re water proof anyhow. |
Fair enough |
Co-authored-by: Procyonae <45432782+Procyonae@users.noreply.github.com>
Co-authored-by: Procyonae <45432782+Procyonae@users.noreply.github.com>
Co-authored-by: Procyonae <45432782+Procyonae@users.noreply.github.com>
Is this ready for review? |
Summary
Content "adds multiple boatloads of new phone case variants, based, mostly, around different horror movies."
Purpose of change
Creating this PR on behalf of Cosmic on the discord, with 99% of the variants here being totally their work. Variants are fun, cool, and interesting, and this PR simply adds more for the sake of building up those numbers.
Describe the solution
This simply adds a whole cinema’s worth of horror-themed phone cases to the already existing variants, with all themed cases balanced to have a much lower spawn chance than their plainly colored brethren.
I placed this PR as a draft as both I and Cosmic are minorly iffy on the acceptability of including name-dropping content within CDDA, lest the armies of copyright lawyers be heard on the march, and figured it would be prudent to place the changes as a draft to see the general consensus and if changes ought to be made.
Describe alternatives you've considered
Going to bed rather than including Xenomorph phone cases in cdda. Unacceptable.
Testing
They simply slot into the existing variants structure, and no syntax errors were reported in the process of linting.
Additional context
See, almost every single horror movie created for context. It might take a while.