Fix and re-enable 3D map memory #66505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
additional safeguards prevent segmentation fault when switching from legacy to 3d draw mode
github-actions
bot
added
[C++]
github-actions
bot
added
the
BasicBuildPassed
|
LGTM but gonna let a few of the usual suspects put eyes on it before merging 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fix and re-enable 3D map memory"
Purpose of change
Map memory always had buggy interactions with 3D vision since #65738. Cross z-level map memory was disabled in #66383 due to memory tiles being drawn on the wrong z-levels being more prominent on isometric tilesets.
Describe the solution
Map memory itself is stored in 3D, but the caching and retrieval of submaps are performed on a single z-level. The relevant code was revised and cross z-level map memory is re-enabled.
Describe alternatives you've considered
Testing
Builds ok
Map memory now works as expected
Memory tiles are drawn on the correct z-level on isometric tilesets
Tested on various tilesets and 3D settings
Additional context