Fish size cleanup #66548
Merged
Fish size cleanup #66548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
|
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to |
|
They should be two back to back cones smh /s |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
In #61614 I audited fish sizes. And like an absolute moron, I calculated them as CUBES. We all know fish are cylinders and not cubes. This is unacceptable. My immersion is ruined.
Describe the solution
Recalculated all the fish as cylinders and not cubes - most now have lower volume, except a few where I miscalculated it in the original PR. A few have changed weights since back then I didn't pick out the correct average weights. Pickerel renamed to Chain pickerel since I forgot to do it the last time.
Also apparently threw the dictionary through a tool to make it alphabetical. Smh people.
Describe alternatives you've considered
Testing
Additional context