Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair Firearm Repair Kit Repair #66664

Merged

Conversation

ashGlaw
Copy link
Contributor

@ashGlaw ashGlaw commented Jul 4, 2023

Summary

Balance "Firearm repair kits used too much energy compared to its own components."

Purpose of change

It makes no sense that a soldering iron would use 1 charge per use, a Gunsmith Repair Kit uses 25, but a Firearm Repair Kit uses 100, given that the only electric tools in either kit are a soldering iron.

Describe the solution

Brought the costs down in line with the Soldering Iron.

Describe alternatives you've considered

I considered that the cost difference was put there as balance, but it seems substantially less necessary now that the kits can be plugged into vehicles anyway.

Testing

I spawned in a firearms repair kit, a gunsmith repair kit, some batteries, and a Glock. I bashed things with the pistol until it was very damaged. I used the kits to repair the gun. Each used only 1 charge.

Additional context

Firearm repair kits used too much energy compared to similar items and its own components.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Game: Balance Balancing of (existing) in-game features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 4, 2023
@GuardianDll
Copy link
Member

it looks like none of them have any battery-powered tools except soldering iron, so i recommend to make activation cost for both of them to be in line with iron

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 4, 2023
@ashGlaw
Copy link
Contributor Author

ashGlaw commented Jul 5, 2023

Even if that'll make repairing a gun or applying a mod much cheaper too? Eh, sure, I'll do it.

@Maleclypse Maleclypse merged commit 57bc9f8 into CleverRaven:master Jul 6, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Game: Balance Balancing of (existing) in-game features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants