Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small adjustments to rattlesnakes #66832

Merged
merged 7 commits into from
Jul 18, 2023

Conversation

randomtyper
Copy link
Contributor

@randomtyper randomtyper commented Jul 11, 2023

Summary

None

Purpose of change

  1. Giant serpents should not be hard to shoot;
  2. IRL rattlers have a very good sense of smell (https://en.wikipedia.org/wiki/Vomeronasal_organ), while ingame ones do not for no reason;
  3. Night vision radius for rattlers was quite small and not really realistically so (because of pit organs https://en.wikipedia.org/wiki/Infrared_sensing_in_snakes);
  4. Size jump from giant rattler to deathrattle was a tad bit too big for my taste, deathrattle HP was low for size;
  5. Deathrattles lacked body horror and abilities for the severity of their mutations;
  6. Rattlers are not counted as animals for some reason;
  7. Snakes can climb pretty damn well IRL, but can't in game;
  8. Snakes do not avoid danger just like zombies, despite being living beings.

Describe the solution

Removed HARDTOSHOOT flag from deathrattle, added KEENNOSE to all rattlers. Increased night vision radius for all rattlers. Slightly decreased deathrattle size. Added slow regeneration (0.5%, 2 HP) to deathrattle, adjusted some descriptions. Confirm your kills, survivors.

Added some other flags to snakes like CLIMBS and AVOID_DANGER_1.

Describe alternatives you've considered

None

Testing

None for now

Additional context

None

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 11, 2023
data/json/monsters/reptile_amphibian.json Outdated Show resolved Hide resolved
data/json/monsters/reptile_amphibian.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 12, 2023
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Jul 12, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added BasicBuildPassed This PR builds correctly, label assigned by github actions json-styled JSON lint passed, label assigned by github actions and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 12, 2023
@randomtyper
Copy link
Contributor Author

@Karol1223, can you give this a go/request further changes?

@Maleclypse Maleclypse merged commit 35f4af8 into CleverRaven:master Jul 18, 2023
20 of 23 checks passed
@randomtyper randomtyper deleted the serpent-miniupdate branch July 18, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants