Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "@ menu improvements"
Purpose of change
I misunderstood an issue, so I fixed this instead.
I guess more changes after #50892.
Added scrolling if needed, better safe than sorry.
Describe the solution
Make info bars scrollable for skills, effects, bionics, and proficiencies. Only effects needed that, but better safe than sorry.
Read about asthma
before
![image](https://private-user-images.githubusercontent.com/13402666/262808147-53ca7845-5452-4d8f-887f-fd7e87949312.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk4NjAxODEsIm5iZiI6MTcxOTg1OTg4MSwicGF0aCI6Ii8xMzQwMjY2Ni8yNjI4MDgxNDctNTNjYTc4NDUtNTQ1Mi00ZDhmLTg4N2YtZmQ3ZTg3OTQ5MzEyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAxVDE4NTEyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM3NjUyOGViYmE2NjEwYTMyNTQyMmRjODE3OGQ4ZDc4YTQ3YTU0NWQyZTg0MDcxZjhiM2Y3NzkwZWE0NDNmODYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.KouDNx_OGG-rpoKDSNdUtQ8RYTPQVAhcIw7Bqxx4bwA)
after
![image](https://private-user-images.githubusercontent.com/13402666/262701400-1df5003e-0656-41d4-bfbc-853afe3e745f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk4NjAxODEsIm5iZiI6MTcxOTg1OTg4MSwicGF0aCI6Ii8xMzQwMjY2Ni8yNjI3MDE0MDAtMWRmNTAwM2UtMDY1Ni00MWQ0LWJmYmMtODUzYWZlM2U3NDVmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAxVDE4NTEyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM2Y2ExNzQ2YTBlYTZjMWNjYmJiOTg1ZTYzYzJlZjI0YjEwYjM5NDAzYTE5ZWZkNjczNzg1NmZkMWRkM2MwNWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.RgRhA9kvkzKA52Cn35E1QIqWK35J3a8RbG9dsD8b63Y)
Unify visual style and underlying code for scrollbars in the info bar for skills, effects, bionics, and proficiencies. And move the scrollbar to the far right.
Srollbar was one to the right
Move the skill tab scrollbar to the right to match others (and always show, if needed).
Srollbar to the right
before
![image](https://private-user-images.githubusercontent.com/13402666/262704085-ed1a238f-4980-4599-9bb2-e9af8f2da3d8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk4NjAxODEsIm5iZiI6MTcxOTg1OTg4MSwicGF0aCI6Ii8xMzQwMjY2Ni8yNjI3MDQwODUtZWQxYTIzOGYtNDk4MC00NTk5LTliYjItZTlhZjhmMmRhM2Q4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAxVDE4NTEyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY2MDk3NjhhMTM4YWE1NjNmNjQ4ZGNmZmIxMTEwODRkYWFmOTg1ZjljMmFmNzdjMjAyYTcwMWMwMDg0MzNmMGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.XsGuCLYDd8Zj-_LV2MVNYK3Gf2DHCOdpiJRjWjyo3tI)
after
![image](https://private-user-images.githubusercontent.com/13402666/262704163-cf3b8801-c5cb-4542-b059-b571b877f4df.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk4NjAxODEsIm5iZiI6MTcxOTg1OTg4MSwicGF0aCI6Ii8xMzQwMjY2Ni8yNjI3MDQxNjMtY2YzYjg4MDEtYzVjYi00NTQyLWIwNTktYjU3MWI4NzdmNGRmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAxVDE4NTEyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNjMzMyNTNkMmE0NDFlMjBkYWQ5ZDVmYTc2NDkwYjM3ZDQ5MDU3OTllNjcyNzcwNDkyZjkyNDY0MWNiMzM0YWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.xg3sanwcyRqtyn7sfQ5foW6B_FlIufnnLMi9kog5VJA)
Fix: Pointing (with the mouse) at a menu selected the previous menu.
Mouse hover
In the speed tab, show
!!!
for values above 1000.!!!
before
![image](https://private-user-images.githubusercontent.com/13402666/262807885-e2365ff6-ec4c-454e-9f7e-f1cff8348689.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk4NjAxODEsIm5iZiI6MTcxOTg1OTg4MSwicGF0aCI6Ii8xMzQwMjY2Ni8yNjI4MDc4ODUtZTIzNjVmZjYtZWM0Yy00NTRlLTlmN2UtZjFjZmY4MzQ4Njg5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAxVDE4NTEyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTBjZDA0OThjMWVlZmU4M2QzMTcwNTNkYmQ3MjgwYzYxYWE4ZTU2NmE3Yjc1NzE1MWE0YzJlM2MxZTM0YWMyMDYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.rUiUg1hXs6WwuVWC6KTwDOLKgX5yxDPE1Ha3-f7fzv0)
after
![image](https://private-user-images.githubusercontent.com/13402666/262807929-160a54fb-9072-4da1-aeca-61bb279c2343.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk4NjAxODEsIm5iZiI6MTcxOTg1OTg4MSwicGF0aCI6Ii8xMzQwMjY2Ni8yNjI4MDc5MjktMTYwYTU0ZmItOTA3Mi00ZGExLWFlY2EtNjFiYjI3OWMyMzQzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAxVDE4NTEyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIxZDdkZjgwNzIxMTg2ZGJiOTNmYjVjNWFiZTAzYTI3N2QyYjNkMWRiZDJmOWYwNDFkZGNiYWI4MDFhNjc3ZjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.DgO7o6pb-SPgcZVt8C6qymavLmWgo6Yoy9d999OqiHw)
Docs: Add implode, and explode keywords to string_split, and string_join, so people like me can find these in a minute rather than 15 minutes.
Search in Sublime Text
Refactor & pointless code removal.
Describe alternatives you've considered
Testing
Enlongate texts to see if wrapping works for skills, bionics, and proficiencies.
See that effects info wraps (e.g. on Asthma).
Resize to check scrollbar appears in the right format just when it's needed. And that no text in the skills tab is overwritten.
Removed spaces seem to be useless, visually checked that it looks the same.
Additional context
Things to do:
You cannot scroll up in the info panel (wrap down) unlike other tabs. This is caused by (only)
if (info_line > 0) {--info_line};
Notes:
![image](https://private-user-images.githubusercontent.com/13402666/262810438-86235ccd-8398-4aa6-8ea0-d279be1a129f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk4NjAxODEsIm5iZiI6MTcxOTg1OTg4MSwicGF0aCI6Ii8xMzQwMjY2Ni8yNjI4MTA0MzgtODYyMzVjY2QtODM5OC00YWE2LThlYTAtZDI3OWJlMWExMjlmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzAxVDE4NTEyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUzMzFhYTBhMGRjMzYyNjhiODUyYTk0ZmM0ZGM4ZTZlYzcyMmNkYTg4NDAyODcwMzMwNGI2NmNkMDg1MGU3NGUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.07z-XV_zlAYbYtrCviJN2qVd3iRSPA7xc0nUJ2H9Qr8)
Stat info isn't scrollable, since it is very much line-by-line handmade.
Until now, it didn't occur to me that I could play two cataclysms at once!