Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ menu UI scrolling #67847

Merged
merged 8 commits into from
Aug 25, 2023
Merged

Conversation

Brambor
Copy link
Contributor

@Brambor Brambor commented Aug 23, 2023

Summary

Interface "@ menu improvements"

Purpose of change

I misunderstood an issue, so I fixed this instead.
I guess more changes after #50892.
Added scrolling if needed, better safe than sorry.

Describe the solution

Make info bars scrollable for skills, effects, bionics, and proficiencies. Only effects needed that, but better safe than sorry.

Read about asthma

before
image


after
image

Unify visual style and underlying code for scrollbars in the info bar for skills, effects, bionics, and proficiencies. And move the scrollbar to the far right.

Srollbar was one to the right

image

Move the skill tab scrollbar to the right to match others (and always show, if needed).

Srollbar to the right

before
image


after
image

Fix: Pointing (with the mouse) at a menu selected the previous menu.

Mouse hover

image

In the speed tab, show !!! for values above 1000.

!!!

before
image


after
image

Docs: Add implode, and explode keywords to string_split, and string_join, so people like me can find these in a minute rather than 15 minutes.

Search in Sublime Text

image

Refactor & pointless code removal.

Describe alternatives you've considered

Testing

Enlongate texts to see if wrapping works for skills, bionics, and proficiencies.
See that effects info wraps (e.g. on Asthma).
Resize to check scrollbar appears in the right format just when it's needed. And that no text in the skills tab is overwritten.
Removed spaces seem to be useless, visually checked that it looks the same.

Additional context

Things to do:
You cannot scroll up in the info panel (wrap down) unlike other tabs. This is caused by (only) if (info_line > 0) {--info_line};

Notes:
Stat info isn't scrollable, since it is very much line-by-line handmade.
Until now, it didn't occur to me that I could play two cataclysms at once!
image

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 23, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 24, 2023
I don't see any difference. I believe it does nothing. But in case it does, I'm making this a separate commit for easy revert.
@Maleclypse Maleclypse merged commit 516ef47 into CleverRaven:master Aug 25, 2023
21 of 25 checks passed
@Brambor Brambor deleted the @-menu-ui-scrolling branch August 26, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants