Make drones drone #73390
Merged
Make drones drone #73390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whirring 'footsteps' and no bleeding mechanical fluid, meant for quadcopter esque drones
github-actions
bot
added
[JSON]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Balance "Make Quadcopter Drones Produce Sound"
Purpose of change
Quadcopter style drones did not produce any sound, which is silly because drones make lots of buzzing whirring rotor noises irl.
Describe the solution
I created a new species called ROBOT_FLYING, which is a copy of ROBOT with a few exceptions - they produce WHIRR footsteps and have the LOUDMOVES flag (the only way to give flying creatures footstep sounds), and they don't bleed mechanical fluid (as drones tend to be electric motors with no hydraulic fluid, oil, etc). I assigned this ROBOT_FLYING species to the base_drone, which is what almost all quadcopters copy-from, so effectively hit all small drones with one change. I assigned this species to the camspy as well. It is a huge quadcopter and might contain fluid it should 'bleed', but the tradeoff of no blood but making sound seemed appropriate to me.
Describe alternatives you've considered
There was a PR, #65781 that wanted to do this using the PARROT system and have the drones 'bark' sounds the way NPC/Migo/etc have their own barks. But the discussion in that PR suggested it should be done using footsteps so I opted for that.
Testing
Eh, basic testing, made sure they make sounds now, not much to test really.
Additional context
The initial issue for this was #55274 which unfortunately is not truly resolved by this PR only partly addressed. There was also the previous PR that ended up being closed which was #65781. This is not a perfect solution, either, you can't manually assign loudness to footstep sounds, flying creatures by code limitations do not make footsteps, and LOUDMOVES flag is the only way to counteract this which again you can't set that volume manually. So it's not ideal, but I can't make c++ changes and am not even sure what I would change.
I'm not sure if giving this to the camspy was the right call because of its huge-ness, and I did not touch the exodii sniper drone because I have no idea what that is and couldn't tell if it has organic components/I've never seen it before so idk.