Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR] Should prevent cheese with old guard doctor #73989

Merged

Conversation

Vgoloshivskiy
Copy link
Contributor

Summary

Bugfixes "Two bugfixes -> Hm12 in trading used wrong key in order to sell again; doctor mission have unique software for each mission"

Purpose of change

Allow buying hm12 again in case of losing it

Prevent cheesing doctor missions by making few usb drives with same lab data and then completing his missions without visiting other locations
Also removed chance of lab data spawning in different location

Describe the solution

replaced key so it can be sold

created new software for each mission

Describe alternatives you've considered

Ordering new hm12 rifle in the same way you can order armor sets

didn't consider any with a doc

Testing

completed mission waited 7 days and reloaded to see does hm12 rifle appears in trading menu

completed missions and checked name of software

Additional context

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display <Bugfix> This is a fix for a bug (or closes open issue) labels May 21, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label May 21, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Extremly compressed research data, observation and experiment statistic.Only pattern you manage to recognise is increase in report amount closer to Cataclysm but also reduction in number of facilities still submiting reports.
  • Large amount of security keys with dates for potenial future access to encrypted arhived data.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

Vgoloshivskiy and others added 2 commits May 21, 2024 22:38
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label May 21, 2024
@Vgoloshivskiy Vgoloshivskiy changed the title Should prevent cheese with old guard doctor [CR] Should prevent cheese with old guard doctor May 21, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label May 22, 2024
@Maleclypse Maleclypse merged commit 22d851b into CleverRaven:master May 25, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants