Updated special companions to use new rules dialog #75045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
NPC / Factions
PatrikLundell
changed the title
github-actions
bot
added
<Bugfix>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix #74967, i.e. repair special companion rules setting to use the new menu rather than fail to bring up removed dialog.
Describe the solution
Copy the new dialog from the general companion dialog and apply it to the three special companions who had the obsolete dialog.
Removed the second broken dialog (also replaced by the menu) from Liam and Luo.
Describe alternatives you've considered
Only do Liam, as that's the only one I can test with a reasonable effort.
Testing
Not testing Luo and Cranberry as the work to recruit them in order to access the dialog is a lot of work. I did not find a way to change a debug spawned NPC into these characters either.
Additional context