Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Check vitamins not powers for concentration breakers #75795

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Aug 18, 2024

Summary

Mods "[MoM] Check vitamins not powers for concentration breakers "

Purpose of change

Noticed that for things like being dazed or set on fire, the EoCs were checking a small subset of specific power effects before rolling to maintain concentration. It's better and more comprehensive to check the concentration vitamin directly.

Describe the solution

Remove list of powers, check vitamin.

Also add a jmath statement to handle all concentration checks and bonuses and route the existing EoCs through it for ease of later maintenance.

Describe alternatives you've considered

Testing

Ran back and forth. Winded broke concentration sometimes, but not all the time.

Waited with powers above limit. Limit broke eventually, but not immediately.

Additional context

A lot of combat buffs were not being checked for in the concentration breaking EoCs, so getting thrown, slipping, being set on fire, being boomered, etc are going to be much more dangerous now.

@Standing-Storm Standing-Storm marked this pull request as draft August 18, 2024 14:01
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions labels Aug 18, 2024
Standing-Storm and others added 2 commits August 18, 2024 09:08
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 18, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review August 20, 2024 18:09
@Maleclypse Maleclypse merged commit a232d0b into CleverRaven:master Aug 22, 2024
24 of 25 checks passed
@Standing-Storm Standing-Storm deleted the patch-1 branch August 22, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants