Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Convert Lifting Hand to power, give Telekinetics a new passive #75816

Merged
merged 19 commits into from
Aug 22, 2024

Conversation

Standing-Storm
Copy link
Contributor

Summary

Mods "[MoM] Convert Lifting Hand to power, give Telekinetics a new passive"

Purpose of change

My original idea was to make Lifting Field a power (it's extremely powerful for a passive ability), but I was hampered by a bug that deleted everything in an integrated container when the container was removed. #75565 fixed that bug, allowing me to switch Lifting Field to its intended implementation.

Describe the solution

Convert Lifting Field to a power, including documentation, learning EoCs, contemplation recipes, and so on. Include an update EoC that converts existing characters over and gives them the appropriate level of Lifting Field.

Replace it as the passive with Grasping Hand, which reduces time to pull items from pockets or containers by 10% + 0.075% per Telekinesis power level.

Describe alternatives you've considered

Testing

The conversion EoC works, removing the Lifting Field recipe and adding the power and concentration recipe. Awakening, taking a hobby, or taking the profession start you with Grasping Hand. The learning EoC triggers, grants the recipe, and the power can be learned. Contemplating it further grants XP to the power. When used, the Lifting Field appears, and when concentration ends it disappears. Maintaining the power grants XP correctly.

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [Markdown] Markdown issues and PRs EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter labels Aug 19, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Your Lifting Field has been updated to a power. You now know the contemplation recipe and have an appropiate level of field for your previous prowess in the ability.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 19, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 19, 2024
@Maleclypse Maleclypse merged commit 72e9afe into CleverRaven:master Aug 22, 2024
24 checks passed
@Standing-Storm Standing-Storm deleted the lifting-hand-to-power branch August 22, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Documentation> Design documents, internal info, guides and help. EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mods: Mind Over Matter Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants