Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #31

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Fix build #31

merged 1 commit into from
Feb 13, 2020

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Feb 11, 2020 •
edited
Loading

  • Temporarily fixes the build. Once #9259 merges, we can pin a specific version for this example so that this build doesn't break with changes to Cloudy.jl's master

Thanks to @rohanmclure (co-authored)!

@codecov
Copy link

codecov bot commented Feb 13, 2020 •
edited
Loading

Codecov Report

Merging #31 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   66.66%   66.66%           
=======================================
  Files          11       11           
  Lines         474      474           
=======================================
  Hits          316      316           
  Misses        158      158

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59edfb2...5b211d5. Read the comment docs.

@charleskawczynski charleskawczynski changed the title Fix submodule ref, update packages Fix build Feb 13, 2020
@charleskawczynski
Copy link
Member Author

bors r+

bors bot added a commit that referenced this pull request Feb 13, 2020
@bors @charleskawczynski
Merge #31
72e1b29 
31: Fix build r=charleskawczynski a=charleskawczynski

 - Temporarily fixes the build. Once [#9259](JuliaRegistries/General#9259) merges, we can pin a specific version for this example so that this build doesn't break with changes to `Cloudy.jl`'s master

Thanks to @rohanmclure (co-authored)!

Co-authored-by: Charles Kawczynski <kawczynski.charles@gmail.com>
@bors
Copy link
Contributor

bors bot commented Feb 13, 2020

Build succeeded

@bors bors bot merged commit 5b211d5 into master Feb 13, 2020
@bors bors bot deleted the ck/FixBuild branch February 13, 2020 19:18
@jakebolewski jakebolewski mentioned this pull request Jun 19, 2020
Merged
bors bot added a commit that referenced this pull request Jun 20, 2020
@bors @jakebolewski
Merge #53
0d57d1f 
53: Unit-tests with CI Update r=jakebolewski a=jakebolewski

closes #31 


Co-authored-by: Melanie Bieli <melanie.bieli@bluewin.ch>
Co-authored-by: jakebolewski <jakebolewski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charleskawczynski