precompute inverse Jacobian #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyrne
force-pushed
the
sb/invj
branch
2 times, most recently
from
b6ba3b7 to
348aab7
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 26, 2022
830: precompute inverse Jacobian r=simonbyrne a=simonbyrne Precompute 1/J to avoid divisions. cc `@charleskawczynski` - [x] Code follows the [style guidelines](https://clima.github.io/ClimateMachine.jl/latest/DevDocs/CodeStyle/) OR N/A. - [x] Unit tests are included OR N/A. - [x] Code is exercised in an integration test OR N/A. - [x] Documentation has been added/updated OR N/A. Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
|
bors r- |
|
Canceled. |
|
bors r+ |
|
bors r- |
|
Canceled. |
|
Sorry, I think merging #829 will actually be a bit quicker since it speeds up CI |
|
There is a small conflict, I can help resolve after |
charleskawczynski
approved these changes
Jul 26, 2022
charleskawczynski
force-pushed
the
sb/invj
branch
from
348aab7 to
017a123
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precompute 1/J to avoid divisions.
cc @charleskawczynski